search

DatabaseGroup / tree-similarity

Library for tree similarity algorithms and queries.
MIT License
75 stars 14 forks source link

Port to vcpkg #24

Closed remz1337 closed 1 year ago

remz1337 commented 1 year ago

I ported this library to vcpkg package manager for easy installation in other projects. For this, I added the install target in CMake, and fixed the relative paths of header files across the src folder.

Also updated the README for installation instruction with VCPKG.

I am assuming my other PR (#23 ) gets merged too. If not, I can drop those commits from this PR. Let me know

remz1337 commented 1 year ago

Changes done!

mateuszpawlik commented 1 year ago

@remz1337, please resolve the conflicts. Merging #23 must have caused it.

remz1337 commented 1 year ago

Should be good now

mateuszpawlik commented 1 year ago

Thank you @remz1337. I'm merging in.

remz1337 commented 1 year ago

Thank you @mateuszpawlik. Can you add a tag/release of the current version? It will be easier to identify/follow future versions with vcpkg. I used v0.1 in my open PR with vcpkg to include tree-similarity in their database, but feel free to use what you prefer and I'll adjust: https://github.com/microsoft/vcpkg/pull/30901

mateuszpawlik commented 1 year ago

With @thuetter we scheduled a little hackathon, mainly for the documentation. Is it easy to update that tag on vcpkg side?

remz1337 commented 1 year ago

pretty easy yes, just need to update the commit hash and version string in the portfile (json file defining the library in vcpkg). I would advise that you create a tag with the current HEAD (76e62627438ea603c9881221f7444c7cb5407b6d) that matches the version string in VCPKG (but it's not mandatory).

Any further revision/release of the library will also need to be updated in vcpkg (otherwise people installing from vcpkg will always download v0.1)

mateuszpawlik commented 1 year ago

I've created a release and tag v0.1.0 - it seemed more correct to include the patch number, following the semantic versioning. It the end it may not matter but since I'm new to versioning I wanted to learn ;-)