search

DatabayAG / InteractiveVideo

ILIAS Interactive Video Plugin
GNU General Public License v3.0
26 stars 22 forks source link

Line for patch #1

Open bogenschlag opened 7 years ago

bogenschlag commented 7 years ago

Regarding the necessity to patch the WAC: In ILIAS 5.2 that seems to be exactly line 1460.

But wouldn’t it be better to include a patch file, that simply inserts a whole “block” like

case "xvid":
    $obj_id = $id;
    break;

into the class file, with the plugin?

gvollbach commented 7 years ago

In my opinion not really, as you can see the lines move since this is actively maintained code, the long term goal is to not require the patch anymore. But for this I must remove all remaining uses of the ilObjMediaObject class.

The Interactive Video Plugin already has a registration for the WebAccessChecker in Version 2, so there is only the "little" work of removing the ilObjMediaObject video type from the plugin sources and migrate all old usages to a new plugin video object type.