Make sure articles are unique

Datafable / epu-index

EPU index

http://www.applieddatamining.com/cms/?q=content/economic-policy-uncertainty-index

1 stars 0 forks source link

Make sure articles are unique #54

Closed bartaelterman closed 9 years ago

bartaelterman commented 9 years ago

Option 1: Set a unique constraint on the articles url. Problem: articles scraped before 2013 don't have a url. (see also #53)
Option 2: Set a unique constraint on a combination of the fields news_journal, published_at and title

bartaelterman commented 9 years ago

Urls are not an option (see #53 ) so we'll have to go for option 2.

@niconoe can we add such a constraint in the models file?

niconoe commented 9 years ago

Yes, it can be implemented using unique_together, and Django will create constraint at the database level. Does that looks good?

bartaelterman commented 9 years ago

Excellent!

peterdesmet commented 9 years ago

Since URLs are still mandatory, I cannot test if articles without URL are displayed nicely on the front end. Don't close this issue until this has been tested.

niconoe commented 9 years ago

The URL is now optional, and unique_together constraint is set (everything deployed to Heroku). I guess this issue + #53 + #63 are now solved, please test!

peterdesmet commented 9 years ago

Frontend works: only shows newspaper name, without link if no URL is available.