search

DatagenTech / dgutils

Apache License 2.0
63 stars 8 forks source link

whitespaces cause a fail in integrity check #1

Closed AsaphLightricks closed 2 years ago

AsaphLightricks commented 2 years ago

https://github.com/DatagenTech/dgutils/blob/1dd0f3dec39896d82350ba5f31393311be11cc18/DataLoader/DatapointHandler.py#L60

Hi @nblochdg,

We use a pre-commit hook that removes trailing whitespaces in files before commiting. This hook removed the last ' ' in dp_struct.txt which then caused this line to fail. Since whitespaces are irrelevant here i suggest changing the line to:

if current_rep.replace(" ", "") != baseline_repr.replace(" ", ""):
nblochdg commented 2 years ago

Thanks for the feedback! Solved