DatagenTech / dgutils

Apache License 2.0
63 stars 8 forks source link

suggestion to add lighting metadata to Datapoint #3

Closed AsaphLightricks closed 1 year ago

AsaphLightricks commented 2 years ago

to: https://github.com/DatagenTech/dgutils/blob/59b518946d29e5be16b2b4808e334f41144fa55f/DataLoader/DatapointHandler.py#L98-L102 add the following:

        if "environment" in fn:
            for env_dict in local_dict["environments"]:
                if env_dict['image_name'] == os.path.basename(self._render_path):
                    local_dict = env_dict
                    break

to: https://github.com/DatagenTech/dgutils/blob/59b518946d29e5be16b2b4808e334f41144fa55f/DataLoader/DatapointHandler.py#L197-L201 add:

            "environment.json " 

to: https://github.com/DatagenTech/dgutils/blob/59b518946d29e5be16b2b4808e334f41144fa55f/DataLoader/Datapoint.py#L55-L58 add:

            # Image modalities handlers. This is a private field. 
            # Use the property fields below to access image modalities 
            image_handlers: Structure 

             # lighting
              image_name: str
              environment: str
              time_of_day: str
              background: str
rlemberskyDatagen commented 1 year ago

Thank you, we will pass the feature request to Product.