search

Datalinker-Org / Geospatial

Apache License 2.0
19 stars 10 forks source link

Examples for Geospatial schema files required by WorkRecordResource #75

Closed donwilson-rezare closed 10 months ago

donwilson-rezare commented 10 months ago

I have created examples and validated them for all of the schema files required by the WorkRecordResource.

cookeac commented 10 months ago

Also this seems to introduce merge conflicts with PR #74

donwilson-rezare commented 10 months ago

@cookeac I have altered the resource types.

I have set schemes for product registration to "nz.govt.nzfsa.eatsafe.acvm.register" and for withdrawals to "nz.govt.nzfsa.eatsafe.acvm.whp". I don't know if these are appropriate. I cannot find a list of WHP's on the ACVM website. Also I have abbreviated the acvm URL somewhat. Is that OK?

I don't know what to do for schemes that might be for commercial companies (e.g. fertiliser companies and testing laboratories). I deliberately avoided using proper company names in case that caused issues.

I have resolved the conflict in lengthMeasureType. I was improving the example.

cookeac commented 10 months ago

@cookeac I have altered the resource types.

I have set schemes for product registration to "nz.govt.nzfsa.eatsafe.acvm.register" and for withdrawals to "nz.govt.nzfsa.eatsafe.acvm.whp". I don't know if these are appropriate. I cannot find a list of WHP's on the ACVM website. Also I have abbreviated the acvm URL somewhat. Is that OK?

Yes, it is good where there are country-specific examples such as these to get them as close to reality as possible. One piece of advice I was given by a leader in a government organisation was that organisational structures or names change regularly over time, while regulated systems and purposes evolve much more slowly. As the scheme URIs don't need to be URLs, you could consider "nz.govt.acvm.register", for instance.

I don't know what to do for schemes that might be for commercial companies (e.g. fertiliser companies and testing laboratories). I deliberately avoided using proper company names in case that caused issues.

You're right not use an actual company name. Ideally over times these lists (e.g. tests) will be standardised across companies and use standard schemes. But at least some will remain company specific, and fictional data in examples is fine.