Datalux / Osintgram

Osintgram is a OSINT tool on Instagram. It offers an interactive shell to perform analysis on Instagram account of any users by its nickname
GNU General Public License v3.0
9.44k stars 2.06k forks source link

im not much of a python programmer anymore but #430

Open TotallyNotAHaxxer opened 2 years ago

TotallyNotAHaxxer commented 2 years ago

I for sure have a question, i figured i would take a peak at the code just to see what truly went behind it, and i have some questions, when you use pretty table to output the data why dont you do

            t.field_names = ['Posts', 'Full Name', 'Username', 'ID']
            t.align["Posts"] = "l"
            t.align["Full Name"] = "l"
            t.align["Username"] = "l"
            t.align["ID"] = "l"

and do that same thing for every under called function instead of just


def(header1, header2, header3, header4):
            t.field_names = [header1, header2 etc etc]
            t.align["Posts"] = "l" # same goes for here 
            t.align["Full Name"] = "l"
            t.align["Username"] = "l"
            t.align["ID"] = "l"

i imaging there is a way you can do that instead of copying the same thing over and over and switching the variable names, i work mainly in languages like Perl, Fortran and GO but i would assume given how flexible python is you could make this work

and the second thing i wanted to ask is why is the banner in a separate file and called from there? i kinda assumed organization so you dont have some ascii banner getting in the way of the code

Dont take this badly i used your scripts alot and think the concept is cool, i just figured a year later i would stop by and make some suggestions or ask a few questions. thank you for your time ~ ArkAngeL43

steam-roller commented 2 years ago

@ArkAngeL43 why don't you do a pull request of this

or "@" datalux with suggestion or something

TotallyNotAHaxxer commented 2 years ago

i thought about it but at the same time i have etched more and more away from python everyday, if i create a pull request to the project it would be most likely inaccurate and unprofessional code