Datatamer / tamr-client

Programmatically interact with Tamr
https://tamr-client.readthedocs.io
Apache License 2.0
11 stars 25 forks source link

Add Python 3.9 to test matrix #496

Closed skalish closed 2 years ago

skalish commented 2 years ago

↪️ Pull Request

This PR extends our testing and official support to cover Python 3.9.

It also bumps the patch versions in .python-version.

💻 Examples

✔️ PR Todo

skalish commented 2 years ago

Seems like the issue of hanging install is fixed by running poetry update locally to bump all dependencies in poetry.lock to newer versions. Any thoughts on whether this is a good or bad idea @pcattori?

pcattori commented 2 years ago

Seems like the issue of hanging install is fixed by running poetry update locally to bump all dependencies in poetry.lock to newer versions. Any thoughts on whether this is a good or bad idea @pcattori?

Seems fine to me as long as our CI test suite passes with the updated versions. To be clear: are you proposing we run poetry.update locally and commit the changes to poetry.lock so that CI picks that up? Or are you suggesting we run poetry.update within the CI script? (I think you mean the former, in which case 👍 )

skalish commented 2 years ago

Seems like the issue of hanging install is fixed by running poetry update locally to bump all dependencies in poetry.lock to newer versions. Any thoughts on whether this is a good or bad idea @pcattori?

Seems fine to me as long as our CI test suite passes with the updated versions. To be clear: are you proposing we run poetry.update locally and commit the changes to poetry.lock so that CI picks that up? Or are you suggesting we run poetry.update within the CI script? (I think you mean the former, in which case 👍 )

Yep, running poetry.update and commiting the new poetry.lock, which I think constitutes a "chore". Please correct if not.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: