Closed Andrew-Wichmann closed 2 years ago
Hi. Thanks for this PR. We currently aren't set up properly for contributions (we're working on it!) The main reason for this is that we have a large bespoke test harness which requires a development environment to be set up to correctly execute the tests.
With your permission I will make this change in our development version and make sure to credit you. Alternatively we can engage to get you set up with this if you are prepared to do this.
Hi. Thanks for this PR. We currently aren't set up properly for contributions (we're working on it!) The main reason for this is that we have a large bespoke test harness which requires a development environment to be set up to correctly execute the tests.
With your permission I will make this change in our development version and make sure to credit you. Alternatively we can engage to get you set up with this if you are prepared to do this.
Nah, you can just make the change. Ty
May I have credit for this please? This would look nice on my resume =) ty
Hi! No problem @Andrew-Wichmann Apologies for not having done this as promised, genuine oversight on my part.
How's this? https://github.com/Datavault-UK/dbtvault/releases/tag/v0.8.0
Objective
Details
Currently, models that use Dbtvault materializations only respect the "--full-refresh" flag on the command line. DBT Core materializations like incremental, however, use the
should_full_refresh
macro do determine if an individual model should fully refresh.This MR changes Dbtvault materializations to use
should_full_refresh
like DBT Core materializations do.