Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
511 stars 131 forks source link

should_full_refresh() in materializations #100

Closed Andrew-Wichmann closed 2 years ago

Andrew-Wichmann commented 2 years ago

Objective

Details

Currently, models that use Dbtvault materializations only respect the "--full-refresh" flag on the command line. DBT Core materializations like incremental, however, use the should_full_refresh macro do determine if an individual model should fully refresh.

This MR changes Dbtvault materializations to use should_full_refresh like DBT Core materializations do.

DVAlexHiggs commented 2 years ago

Hi. Thanks for this PR. We currently aren't set up properly for contributions (we're working on it!) The main reason for this is that we have a large bespoke test harness which requires a development environment to be set up to correctly execute the tests.

With your permission I will make this change in our development version and make sure to credit you. Alternatively we can engage to get you set up with this if you are prepared to do this.

Andrew-Wichmann commented 2 years ago

Hi. Thanks for this PR. We currently aren't set up properly for contributions (we're working on it!) The main reason for this is that we have a large bespoke test harness which requires a development environment to be set up to correctly execute the tests.

With your permission I will make this change in our development version and make sure to credit you. Alternatively we can engage to get you set up with this if you are prepared to do this.

Nah, you can just make the change. Ty

Andrew-Wichmann commented 2 years ago

May I have credit for this please? This would look nice on my resume =) ty

DVAlexHiggs commented 2 years ago

Hi! No problem @Andrew-Wichmann Apologies for not having done this as promised, genuine oversight on my part.

How's this? https://github.com/Datavault-UK/dbtvault/releases/tag/v0.8.0