#123 make forced upper case configurable

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)

https://www.automate-dv.com

Apache License 2.0

492 stars 121 forks source link

#123 make forced upper case configurable #158

Closed DVJocelynShannon closed 1 year ago

DVJocelynShannon commented 2 years ago

Adding feature to make forced upper case in hashing optional.

DVAlexHiggs commented 2 years ago

Thank you for this! Just to note I've changed the PR target to develop, we don't merge directly to master. I will review this today

DVAlexHiggs commented 2 years ago

Suggestions:

Call the parameter disable_upper_in_hash
Default to UPPER
Option should be DISABLED
Allows for future LOWER and other options

DVAlexHiggs commented 2 years ago

@DVTimWilson @DVJocelynShannon Can you look into the test failures here and resolve please. Thanks

DVJocelynShannon commented 2 years ago

@DVAlexHiggs @DVTimWilson All tests have now successfully passed.

jelledv commented 1 year ago

Any reason why this was closed?

DVAlexHiggs commented 1 year ago

Any reason why this was closed?

We've moved our PRs to a separate repo, it's still going to be added :)