search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
513 stars 131 forks source link

[BUG] Issues with column name escaping approach #168

Closed DVAlexHiggs closed 1 year ago

DVAlexHiggs commented 2 years ago

Describe the bug

A feature we released back in 0.8.0 has been causing some problems ever since: Column Name Escaping.

We originally implemented this to account for problem columns coming from source data, such as reserved words and columns with spaces in them.

We are re-thinking the design of this as it is having unexpected consequences and is becoming painful to maintain.

Essentially, we will be stripping all use of column escaping from everywhere but staging, and even then will only provide the functionality through a toggle. This toggle already exists and is well documented.

This should have been how it was implemented from the start, and we apologise for any inconvenience this has caused!

Bug reports

We've had a lot of community feedback on this issue, so your issue may have already been raised, however if you feel you've found another case where this is causing problems, please submit another report.

The following existing bug reports are related to this issue:

anouar-zh commented 2 years ago

Hi! Any idea when you will release a new version?

DVAlexHiggs commented 1 year ago

@anouar-zh Good progress has been made on this and we should have all of these issues fixed in the next release (later this week). Thank you for your patience!

DVAlexHiggs commented 1 year ago

0.9.1 Released which should address the majority of these problems. Thanks everyone for you patience! Please let us know if you continue to have issues