[BUG] Staging macro will miss a comma if not including source columns

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)

https://www.automate-dv.com

Apache License 2.0

510 stars 131 forks source link

[BUG] Staging macro will miss a comma if not including source columns #17

Closed balmasi closed 3 years ago

balmasi commented 3 years ago

https://github.com/Datavault-UK/dbtvault/blob/a90f480832b594b256dfd736a6619766eb30198a/macros/staging/stage.sql#L48-L64

Basically, I think line 48 shouldn't have and include_source_columns cause line 58 can still get triggered without a preceding comma

DVAlexHiggs commented 3 years ago

v0.7.1 Released, Please close this if fixed.