search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
478 stars 114 forks source link

Normalize table and column title casing #216

Closed ZacharyMcGuire closed 4 months ago

ZacharyMcGuire commented 8 months ago

Table and column names in sat.sql and as_of_date_window.sql were changed to lower-case and upper-case respectively for standardization across the codebase. This change ensures case-insensitive handling of these entities.

Addresses the following issues:

There may be other instances where case sensitive collation runs into issues, but these are the two I (and others) have noticed.

I've tested these changes on my instance of SQL Server 2017, but have not conducted any extensive testing on other DBs.

P.S. contributing guideline still references dbt-vault. Please let me know if there's anything further I should add to this PR.

DVAlexHiggs commented 4 months ago

Hi @ZacharyMcGuire Unfortunately as our contribution process currently means we cannot accept direct contributions, we've gone ahead and carried out these changes internally, however I would like to attribute you. Does this work for you?

ZacharyMcGuire commented 4 months ago

@DVAlexHiggs hey mate,

That's no problem, appreciate the issues being resolved, however that gets achieved! 🙂

DVAlexHiggs commented 4 months ago

Fixed in v0.10.2 😄