search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
478 stars 114 forks source link

[BUG] A link may have multiple source_models, but an effectivity satellite may only have one. #225

Closed mjahammel closed 5 months ago

mjahammel commented 5 months ago

Describe the bug The "source_model" parameter for a link allows either a singular string or a list of strings. The same parameter for the effectivity satellite accepts only a singular string. As effectivity satellites are associated with links, should they not be able to built using the same set of source models as the parent link?

Environment

dbt version: automate_dv version: 0.10.1 Database/Platform: Snowflake

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Log files If applicable, provide dbt log files which include the problem.

Additional context Add any other context about the problem here.

DVAlexHiggs commented 5 months ago

Hi! Thanks for this report.

This is already an open feature request so I will be closing in favour of #131