search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
510 stars 131 forks source link

[BUG] Ghost Record Macro not working when multiple src_pk columns #232

Closed ambullo closed 5 months ago

ambullo commented 6 months ago

We activated ghost records in our config but run into some issues.

We have multiple columns for the src_pk of our satellites. However, the macro for the ghost records does not accept multiple columns at this point. Therefore it will just ignore them and we run into a compilation error when we want to run the model.

The macro needs to be adjusted to accept multiple src_pk columns and handle them correctly. Point in the code where the issue occurs: https://github.com/Datavault-UK/automate-dv/blob/f0cf634083b0c318f345bd19f159d6eb138e137f/macros/supporting/ghost_records/create_ghost_record.sql#L34

AB#5345

DVAlexHiggs commented 6 months ago

Hi! Thank you for bringing this to our attention - it was an oversight on our part. We'll make sure a fix is including in our upcoming release. Thanks!

DVAlexHiggs commented 5 months ago

Fixed and released in v0.11.0, Thank you for your patience on this one!

If the issue persists, please re-open this issue.