search

Datavault-UK / automate-dv

A free to use dbt package for creating and loading Data Vault 2.0 compliant Data Warehouses (powered by dbt, an open source data engineering tool, registered trademark of dbt Labs)
https://www.automate-dv.com
Apache License 2.0
513 stars 131 forks source link

New version of multi active satellite macro #80

Closed DVTimWilson closed 3 years ago

DVTimWilson commented 3 years ago

AB#1989 New version of multi active satellite macro for Snowflake, MSSQL and BigQuery. Also additional test coverage. Documentation update here: Datavault-UK/dbtvault-docs#14

DVAlexHiggs commented 3 years ago

This looks really nice. So good to see this simplified so much!

Excited to get this to our users, thank you for your work 💯

DVTimWilson commented 3 years ago

Failure of automated test due to timeout, possibly because 'mas_one_cdk_base_sats_rank_mat' was specified twice in separate jobs? Pushed changes for this, and also added a missing test to the 1cdk job spec and removed a stray comma.

DVAlexHiggs commented 3 years ago

Thanks Tim. Just one observation, why do we have feature files called x_updated.feature? this is not very clear, and it also leads me to believe there may be duplication in tests between these and the same feature files without the _updated can you confirm?

DVTimWilson commented 3 years ago

Thanks Tim. Just one observation, why do we have feature files called x_updated.feature? this is not very clear, and it also leads me to believe there may be duplication in tests between these and the same feature files without the _updated can you confirm?

Doh! things left behind and all that. We'll get this sorted out shortly.

DVTimWilson commented 3 years ago

Thanks, I can now merge this, however the file is still called "_updated" please change this once merged.

Ah, I overlooked the renaming of the BQ and MSSQL versions, sorry. Will sort out.

DVAlexHiggs commented 3 years ago

test/features/ma_sats/bigquery/bigquery_mas_one_cdk_0_base_updated.feature