DataverseLabs / pyinterpolate

Kriging | Poisson Kriging | Variogram Analysis
https://pyinterpolate.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
147 stars 26 forks source link

Decouple two different types of input for one parameter - `model_types` in `TheoreticalVariogram` class and make two parameters instead #401

Closed SimonMolinsky closed 1 year ago

SimonMolinsky commented 1 year ago

Is your feature request related to a problem? Please describe. TheoreticalVariogram methods take the model_types parameter which can be str and List type. It makes application logic more complex, and debugging everything takes more work. Variogram is a central part of the package and shouldn't have such quirks.

Describe the solution you'd like Create two parameters instead of one: model_name (str) and model_types (List[str]), where model_types=None is a default init.

Describe alternatives you've considered n/a

Additional context This change will propagate into multiple classes and functions within packages, so tests and tutorial checks are crucial.