search

Datawheel / canon-stats

Reusable statistical and complexity calculations using NodeJS and Express
1 stars 1 forks source link

[eci] api call doesnt work with parents=true #30

Closed AlanORB closed 3 years ago

AlanORB commented 3 years ago

https://dev.oec.world/api/stats/eci?cube=trade_s_jpn_m_hs&rca=Region,HS4,Trade+Value&Year=2013,2014,2015&method=subnational&ranking=true&debug=true&parents=true&Trade+Flow=2&cubeRight=trade_i_baci_a_92&rcaRight=Exporter+Country,HS4,Trade+Value&YearRight=2016,2017,2018&aliasRight=Country,HS4&threshold=CountryRight:3000000000,HS4Right:1500000000,Subnat+Geography:300000000&eciThreshold=Subnat+Geography:10 doesnt works

https://dev.oec.world/api/stats/eci?cube=trade_s_jpn_m_hs&rca=Region,HS4,Trade+Value&Year=2013,2014,2015&method=subnational&ranking=true&debug=true&parent=true&Trade+Flow=2&cubeRight=trade_i_baci_a_92&rcaRight=Exporter+Country,HS4,Trade+Value&YearRight=2016,2017,2018&aliasRight=Country,HS4&threshold=CountryRight:3000000000,HS4Right:1500000000,Subnat+Geography:300000000&eciThreshold=Subnat+Geography:10 works

The difference between both, is that above has parents=true, and below has parent=true The problem goes further, while

https://dev.oec.world/api/stats/eci?cube=trade_s_jpn_m_hs&rca=Region,HS4,Trade+Value&Year=2015,2016,2017&method=subnational&ranking=true&debug=true&Trade+Flow=2&cubeRight=trade_i_baci_a_92&rcaRight=Exporter+Country,HS4,Trade+Value&YearRight=2016,2017,2018&aliasRight=Country,HS4&threshold=CountryRight:3000000000,HS4Right:1500000000,Subnat+Geography:300000000&eciThreshold=Subnat+Geography:10&parent=true doesnt work

https://dev.oec.world/api/stats/eci?cube=trade_s_jpn_m_hs&rca=Region,HS4,Trade+Value&Year=2015,2016,2017&method=subnational&ranking=true&debug=true&Trade+Flow=2&cubeRight=trade_i_baci_a_92&rcaRight=Exporter+Country,HS4,Trade+Value&YearRight=2016,2017,2018&aliasRight=Country,HS4&threshold=CountryRight:3000000000,HS4Right:1500000000,Subnat+Geography:300000000&eciThreshold=Subnat+Geography:10&parents=true works

In this case, above has parents=true and works, and below has parent=true and doesn't work

AlanORB commented 3 years ago

it does work properly with &parents=false

AlanORB commented 3 years ago

they do die with &locale=es and this is needed for the translations

davelandry commented 3 years ago

this could be a great first issue for @mcperez2?

cc @hermosillajelmy and @jhmullen

AlanORB commented 3 years ago

with @hermosillajelmy we found that the major issue comes with the @parents=true, but the thing that bothers me is that in some cases works and some doesnt work, the locale doesnt make major problems but until we dont have the spanish translations I will have it on mind

hermosillajelmy commented 3 years ago

the problem was not an issue, it was that the oec was down

AlanORB commented 3 years ago

when the server went up, the queries started working in any cases, so it was not a code issue