redesigns generator editor, API input/output, and variable lists (closes #1335)

Datawheel / canon

Reusable React environment and components for creating visualization engines.

GNU General Public License v3.0

27 stars 7 forks source link

redesigns generator editor, API input/output, and variable lists (closes #1335) #1341

Closed davelandry closed 2 years ago

davelandry commented 2 years ago

@jhmullen I moved around a buuuuuunch of shit here, so please take a look and see if I'm doing everything correctly in this new memoize land please!

jhmullen commented 2 years ago

@davelandry I've got some crunchy wrapping columns when I test so you may need to have another look at the CSS:

jhmullen commented 2 years ago

A few more things:

Please resolve the conflicts with ApiInput that are currently preventing a merge
I like the inline API editor a lot - but I am missing the autocomplete feature for variables. If you have time, can the API bar use richTextEditor with some kind of auto-complete? I am glad to take this on if you just want to leave it as a vanilla textbar for now.

davelandry commented 2 years ago

@jhmullen this is ready for a re-review! I think I'm starting to understand hooks... thank you for your patience 😅

davelandry commented 2 years ago

@jhmullen I punted on ApiInput auto-complete for now... but wouldn't mind jumping in there and figuring it out if needed in a different PR