davelandry
commented
4 years ago @nicoperezmundaca I just reviewed your implementation with Alex, and we think it's overkill for what we need.
- It was confusing to track down how everything gets rendered. It would actually be easier to edit text in JSX, because you'd be able to see exactly where certain text lives on the page, rather than trying to hunt it down in the locale file by key. Move all of the content into JSX, and if needed, make smaller components for re-used elements (like team bios).
- The URL query param method is also overkill, please just to routes that match the routes of the old site (I'm going to update the checklist above with these routes). You can still use a variable in the route to conditionally render the correct component (ie.
path="/:lang/resources/:page"
/en/resources/about)/en/resources/data)/en/resources/methodology)/en/resources/permissions)/en/resources/faqs)/publications, but please make it/en/resources/publicationsand include a redirect)/api, but please make it/en/resources/apiand include a redirect)