search

Datawheel / pantheon2

2.0 Update to the Pantheon Site
GNU Affero General Public License v3.0
1 stars 0 forks source link

upgrade to react router 4? #154

Closed alexandersimoes closed 5 years ago

alexandersimoes commented 7 years ago

Can we update the code base to react-router v4? There are a lot of breaking changes especially for SSR but here are some potential helpful docs:

https://ebaytech.berlin/universal-web-apps-with-react-router-4-15002bb30ccb https://github.com/technology-ebay-de/universal-react-router4/blob/master/src/server/index.js https://reacttraining.com/react-router/web/guides/server-rendering https://stackoverflow.com/questions/42797543/whats-wrong-with-this-reactrouter-match-implementation/42798535#42798535 https://github.com/ReactTraining/react-router/issues/4558

alexandersimoes commented 5 years ago

Now that we're on canon, no need to worry about this.