search

Datenschule / jedeschule-scraper

MIT License
22 stars 15 forks source link

Test models #68

Closed k-nut closed 4 years ago

k-nut commented 4 years ago

Curiously the test fail with Python3.8 when pip installing here. @stefanw did you manage to run it with 3.8 locally?

stefanw commented 4 years ago

The test fail seems to be a failing install of libxml (missing headers?).

k-nut commented 4 years ago

Nice, that actually was what it was. Fixed here: 502b9451edbf2a2

knutator2 commented 4 years ago

i think it would be nice to clear the database before the test, so we have a clean db and know its state. What do you think?

k-nut commented 4 years ago

@knutator2 as the ./test.sh script creates a temporary database and removes it afterwards we know that the data will always be in the same state, don't we?

knutator2 commented 4 years ago

ah ok, i didn't recognize, the tests depend on each other. I just thought every test should assume an empty database and sets up the database as needed for the test. Nevertheless, works for me right now