Datenschule / jedeschule-scraper

MIT License
22 stars 15 forks source link

[CONFLICTS] Created Nordrhein-Westfalen #92

Closed htw-kevkev closed 3 years ago

htw-kevkev commented 3 years ago

Main changes in comparison to nw-method in run.py:

k-nut commented 3 years ago

I pushed a rebased version of this in #105. The goal was tor run the new diff script. You can find the results here.

As you can see there are just two differences:

The changes are fairly minimal because I had also created an updated version of the NRW scraper in #77. I personally prefer my version of this as it is much shorter and - I would argue - therefore easier to maintain long term. I would hence vote to close this PR. If wanted maybe we can create an issue to also scrape the providers for this state but then handle that in a separate PR?

What do you think?

k-nut commented 3 years ago

We decided on using #110 instead for simplicity.