search

Datera / rtslib

The Linux SCSI Target API
http://linux-iscsi.org
Apache License 2.0
19 stars 17 forks source link

bugfix: error when auto-generate IQN based on hostname including '_' #11

Closed ls-zhu closed 8 years ago

ls-zhu commented 8 years ago

Hi, This patch can fix a bug ： we will see a failure when try to create a IQN automaticly based on host name including "_":

Leap_Targetcli3:/ # hostname Leap_Targetcli3

Before: /> iscsi/ create Invalid iqn wwn: iqn.2003-01.org.linux-iscsi.leap_targetcli3.x8664:sn.5d7616d49748 /> exit

Now:

/> iscsi/ create Created target iqn.2003-01.org.linux-iscsi.leap-targetcli3.x8664:sn.a844b6d60014. Selected TPG Tag 1. Created TPG 1.

rickysarraf commented 8 years ago

Is that "_" underscore, or "-" hyphen ? Because in the 2nd create attempt in your example, you've used the hyphen. On Thu, 2016-01-07 at 23:59 -0800, izhu wrote:

Hi, This patch can fix a bug ： we will see a failure when try to create a IQN automaticly based on host name including "_": Leap_Targetcli3:/ # hostname Leap_Targetcli3 Before: /> iscsi/ create  Invalid iqn wwn: iqn.2003-01.org.linux- iscsi.leaptargetcli3.x8664:sn.5d7616d49748 /> exit Now: /> iscsi/ create  Created target iqn.2003-01.org.linux-iscsi.leap- targetcli3.x8664:sn.a844b6d60014. Selected TPG Tag 1. Created TPG 1. You can view, comment on, or merge this pull request online at:   https://github.com/Datera/rtslib/pull/11 Commit Summary bugfix: error when auto-generate IQN based on hostname including '' File Changes M rtslib/target.py (1) M rtslib/utils.py (3) Patch Links: https://github.com/Datera/rtslib/pull/11.patch https://github.com/Datera/rtslib/pull/11.diff —

Reply to this email directly or view it on GitHub.

Ritesh Raj Sarraf RESEARCHUT - http://www.researchut.com "Necessity is the mother of invention."

ls-zhu commented 8 years ago

@rickysarraf It is "_" which should be replaced to "-", I will resubmit it again