Datera / rtslib

The Linux SCSI Target API
http://linux-iscsi.org
Apache License 2.0
19 stars 17 forks source link

AARCH64 Issue #22

Open pankajgarg03 opened 7 years ago

pankajgarg03 commented 7 years ago

In the file trslib/utils.py, function list_eth_names, the following line of code is used to identify a 64 bit OS. os.uname()[4].endswith("_64"):

However this works for x86 since the 64 bit version ends in x86_64. On ARM though, the architecture is AARCH64. This code breaks down and makes the wrong assumption.

The bug can be simply be fixed by changing the _64 to 64.

-Pankaj

rickysarraf commented 7 years ago

On Mon, 2017-03-06 at 13:55 -0800, pankajgarg03 wrote:

In the file trslib/utils.py, function list_eth_names, the following line of code is used to identify a 64 bit OS. os.uname()[4].endswith("_64"): However this works for x86 since the 64 bit version ends in x86_64. On ARM though, the architecture is AARCH64. This code breaks down and makes the wrong assumption. The bug can be simply be fixed by changing the _64 to 64.

I would rather prefer this to be explicitly defined to the respective architecture string.

-- Ritesh Raj Sarraf RESEARCHUT - http://www.researchut.com "Necessity is the mother of invention."

rickysarraf commented 7 years ago

Ah!. Wrong forum. Sorry for the noise.