search

Datera / rtslib

The Linux SCSI Target API
http://linux-iscsi.org
Apache License 2.0
19 stars 17 forks source link

"make rpm" on CentOS 6.5 fails due to too many dashes in filename #3

Closed ExecDevOps closed 9 years ago

ExecDevOps commented 9 years ago

When running "make rpm" on CentOS 6.5, it fails stating that the version (filename) contains illegal character, i.e. it only allows one dash ("-") in the name. By adding an extra filter to the creation of the VERSION variable this can be eliminated.

sed -i -e "s/(^VERSION =.))/\1 | tr - \~)/" ./Makefile

  • result in the file, note the extra pipeing to tr at the end:

VERSION = $$(echo $(GIT_DESC) | sed s/^$(GIT_LAST_TAG)/$(GIT_PKG_TAG)/ | tr - ~)

This may not be the prettiest solution but it works to eliminate this bug.

tramjoe commented 9 years ago

Same as configshell issue #1 This is a known regression from 2.x branch, and is scheduled to be fixed soon. Thanks for reporting!

tramjoe commented 9 years ago

This has been fixed and tested on RHEL6.5 and RHEL7, both work just fine now.