Datera / rtslib

The Linux SCSI Target API
http://linux-iscsi.org
Apache License 2.0
19 stars 17 forks source link

Add qla2xxx_wwn WWN type #5

Open bootc opened 9 years ago

bootc commented 9 years ago

The qla2xxx_wwn type is used in policy/fabric_qla2xxx.lio but is not a valid type in rtslib.config.Config.validate_val(). This commit adds validation for this type in rtslib.config.Config.validate_val() and rtslib.utils.is_valid_wwn().

This allows a system with existing targets (created by an older targetcli/lio-utils) to be validated by rtslib and for the configuration to be saved.

Signed-off-by: Chris Boot bootc@bootc.net

tramjoe commented 9 years ago

Hi Chris,

Thanks for the report, this will be fixed soon. I am not sure what happened there, I think I messed it up when merging local trees. Will check that out real soon.

Best Regards,

Jerome

On 12/17/2014 10:59 PM, Chris Boot wrote:

The qla2xxx_wwn type is used in policy/fabric_qla2xxx.lio but is not a valid type in rtslib.config.Config.validate_val(). This commit adds validation for this type in rtslib.config.Config.validate_val() and rtslib.utils.is_valid_wwn().

This allows a system with existing targets (created by an older targetcli/lio-utils) to be validated by rtslib and for the configuration to be saved.

Signed-off-by: Chris Boot bootc@bootc.net mailto:bootc@bootc.net


    You can merge this Pull Request by running

git pull https://github.com/bootc/rtslib master

Or view, comment on, or merge it at:

https://github.com/Datera/rtslib/pull/5

    Commit Summary

— Reply to this email directly or view it on GitHub https://github.com/Datera/rtslib/pull/5.

fulljackz commented 8 years ago

Hi,

These PR solve this bug : https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764005 on Proxmox 4 with Debian Jessie and 4.2 Kernel

Thanks.