search

Datera / rtslib

The Linux SCSI Target API
http://linux-iscsi.org
Apache License 2.0
19 stars 17 forks source link

target: fix broken TPG enable=0 handling #9

Closed ddiss closed 8 years ago

ddiss commented 9 years ago

A "TPG cannot be disabled" error is incorrectly thrown when attempting to apply a configuration with a disabled TPG.

I think the intention of the code was to fail disable requests if the $tpg/enable configfs path doesn't exist, and only write to the path if it's current value doesn't match the requested setting... The logic was just incorrect.

Signed-off-by: David Disseldorp ddiss@suse.de

ddiss commented 9 years ago

Ping, any feedback?

ddiss commented 8 years ago

I'll assume this repo has been abandoned and proceed with targetcli-fb instead.