search

Dav1dde / gl3n

OpenGL Maths for D (not glm for D).
http://dav1dde.github.com/gl3n/
Other
103 stars 49 forks source link

[proposal] adding a member function to_axisAngle() in struct Quat #92

Closed Fr3nchK1ss closed 3 years ago

Fr3nchK1ss commented 3 years ago

I have a unittested func which retrieves the axis / angle transformation vector from a Quaternion. This function would be added to the struct Quaternion. This is a common function of linear algebra when it comes to quaternion computations. I use it in a game engine. Prototype:
vec3 to_axisAngle()

What do you think? Is it in the spirit of gl3n? Should I pull request?

Dav1dde commented 3 years ago

Sounds good, honestly was surprised that didn't exist. Regarding the naming, I think to_axis_angle would fit the rest of the code better.