search

DavBfr / dart_barcode

Barcode generation library
https://pub.dev/packages/barcode
Apache License 2.0
132 stars 41 forks source link

Fix EAN2 incorrect encoding issue #65

Closed shinbin closed 6 months ago

shinbin commented 7 months ago

I hope this pull request finds you well. I refer to ( https://en.wikipedia.org/wiki/EAN-2 ) and fixed the convert function of ean2.dart. I use websites ( https://www.online-barcode.com/ ) and other methods to verify whether the ean2 code is correct. I would appreciate your consideration for merging it into the main repository and update it to ( https://pub.dev/packages/barcode ) .

Thank you for your time and consideration.

Best regards, Andy (@shinbin)

shinbin commented 6 months ago

@DavBfr Thanks you for your replies. I've rollbacked some of the changes you suggested.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fa6a307) 84.07% compared to head (b286841) 84.08%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #65 +/- ## ========================================== + Coverage 84.07% 84.08% +0.01% ========================================== Files 32 32 Lines 2298 2300 +2 ========================================== + Hits 1932 1934 +2 Misses 366 366 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DavBfr commented 6 months ago

Thanks!