search

DavHau / nix-portable

Nix - Static, Permissionless, Installation-free, Pre-configured
MIT License
870 stars 31 forks source link

Spaces in paths not escaped. — **Does `rm -rf` on arbitrary paths**, I think? #44

Open will-ca opened 1 year ago

will-ca commented 1 year ago 
$ echo "$NP_LOCATION"
/home/User/Files/Subdirectory With Spaces In Name/MoreFiles/Project

$ ./nix-portable nix-shell ./shell.nix
./nix-portable: line 42: test: /home/User/Files/Subdirectory
/home/User/Files/Subdirectory With Spaces In Name/MoreFiles/Project/.nix-portable/busybox/bin/busybox: No such file or directory
will-ca commented 1 year ago

https://github.com/DavHau/nix-portable/blob/ce30382f48a42b13179f5b23a85b1e81b46ed5e7/default.nix#L373-L374

https://github.com/DavHau/nix-portable/blob/ce30382f48a42b13179f5b23a85b1e81b46ed5e7/default.nix#L380-L381

…Well. That's scary.

Let's not go through this again, shall we?