search

DavHau / nix-portable

Nix - Static, Permissionless, Installation-free, Pre-configured
MIT License
779 stars 29 forks source link

Follow a linked NP_LOCATION #76

Closed erooke closed 7 months ago

erooke commented 7 months ago

Aims to fix #75.

If $NP_LOCATION is linked to a location broot will fail to start. This dereferences any link in $NP_LOCATION. I have not tested it beyond confirming that it works on my local machine and my HPC cluster.

CamoCatX commented 7 months ago

Do you know why it fails on Debian and Ubuntu? It seems like the error for the Debian is the build tools are the wrong platform. Looking at other pull requests, it seems this common. Is your HPC (High Performance Computing) cluster on AARCH64?

erooke commented 7 months ago

Do you know why it fails on Debian and Ubuntu?

The Ubuntu error has to do with it failing to download the qemu image which I reckon is what #80 is solving. The Debian error is more confusing to me, as you said it looks to be a cross compiling issue (failing to build for arm on x86) but I'm not sure what about my change would have broken that.

Is your HPC (High Performance Computing) cluster on AARCH64?

Nah, it's x86_64.

DavHau commented 7 months ago

the aarch64 vm tests run on x86 host with qemu emulation. It should not need to build anything for aarch64, but somehow it does. I'll just add binfmt to the vm tests as well: 1fa859a110e1dfdcad7c2a11d3ddb65f97629582

DavHau commented 7 months ago

That thing is merged now. Could you rebase and see if the pipeline passes now?

DavHau commented 7 months ago

Whatever, I'll have to debug the pipeline more. This commit is for sure not the reason it breaks