search

Dave-Vallance / bt-ccxt-store

Fork of Ed Bartosh's CCXT Store Work
MIT License
423 stars 187 forks source link

fixes for #27 and fix of broker's get_wallet_balance() for live trading #30

Closed planet-winter closed 2 years ago

planet-winter commented 4 years ago

Hi @Dave-Vallance

I hope the following helps. It is fixing two things at once.

First issue I had with #27 which renders bt-ccxt-store unusable on some exchanges as given params are not accepted on all exchanges. See https://github.com/ccxt/ccxt/wiki/Manual#custom-order-params. I mitigated it by trying the API call once. If unsuccessful it is not carried out in future to save API calls while still having the feature of @obiben.

The other thing is get_wallet_balance() in the broker which fails for me on a Bitfinex paper trading account if the amount of a currency is zero. eg. if all TESTUSD have been exchanged for TESTBTC, this fails.

Cheers

planet-winter commented 4 years ago

Hi @Dave-Vallance

In the meantime I have corrected and added more patches to my master, like 40819af, being unrelated. Please let me know if and for which fix I should create new PRs for you to make it easier.

Cheers

Dave-Vallance commented 2 years ago

Thanks - looks good after review.