Dave-Vallance / bt-ccxt-store

Fork of Ed Bartosh's CCXT Store Work
MIT License
423 stars 187 forks source link

Binance v3 API forbids 'created' parameter #43

Open mped-oticon opened 3 years ago

mped-oticon commented 3 years ago

Hi

During live trading against Binance, I am met with the error message:

"code":-1104,"msg":"Not all sent parameters were read; read '9' parameter(s) but was sent '10'."

It seems Binance is a bit strict, discarding order-requests if they transmit unknown parameters. The 'created' parameter is outside Binance's v3 API, hence all trading orders are discarded.

Removing this line, should fix it: https://github.com/Dave-Vallance/bt-ccxt-store/blob/8db1455607188761fdf3b8a4da3927c9c1ab3657/ccxtbt/ccxtbroker.py#L225

sadeghyeganehzadeh1997 commented 2 years ago

Fix for error code -1104: make sure you are using "POST" method when sending request, as it is mentioned in binance API documentation that to use POST /api/v3/order (HMAC SHA256) for new order. by mistake, I used "GET" and got the error, after I corrected it to "POST", problem solved.

sadeghyeganehzadeh1997 commented 2 years ago

Fix for error code -1104: make sure you are using "POST" method when sending request. By mistake, I used "GET" method, so binance only see required fields in query string and drops other fields. After I corrected it and replace it with "POST", problem solved.

PGASimon commented 7 months ago

when you corrected what? the unde

Fix for error code -1104: make sure you are using "POST" method when sending request. By mistake, I used "GET" method, so binance only see required fields in query string and drops other fields. After I corrected it and replace it with "POST", problem solved.

when you corrected what? the underlying get request in the binance ccxt file?