Dave-Vallance / bt-ccxt-store

Fork of Ed Bartosh's CCXT Store Work
MIT License
423 stars 187 forks source link

Binance: Fix error code 1104: Don't send v3-unspecified 'created'-field #44

Closed mped-oticon closed 2 years ago

mped-oticon commented 3 years ago

Binance api/v3/order does not mention the 'created' field. Binance seems strict about parameter-checking, and will refuse to execute a request containing extra/unspecified fields.

So we were previously met with: "code":-1104,"msg":"Not all sent parameters were read; read '9' parameter(s) but was sent '10'

mped-oticon commented 3 years ago

This appears to be the fix for Issues: https://github.com/Dave-Vallance/bt-ccxt-store/issues/43 https://github.com/Dave-Vallance/bt-ccxt-store/issues/42

mped-oticon commented 3 years ago

Note: I do not know if any other use-cases requires this 'created' field. I guess not, as cctx itself adds its own 'timestamp' field.

Dave-Vallance commented 2 years ago

Think this might have been addressed in another PR. If you still feel it is needed, please resubmit and address the conflicting files if possible.

Appreciate the contribution!