search

Dave-Vallance / bt-ccxt-store

Fork of Ed Bartosh's CCXT Store Work
MIT License
422 stars 185 forks source link

Multi exchange broker mappings #9

Open sandroboehme opened 5 years ago

sandroboehme commented 5 years ago

As promised, this is the PR for #7 "Enhance the broker mappings and store them for multiple exchanges". But it's a bigger one. There one thing I'm not sure about: As I extend the Binance specific broker from CCXTBroker I wanted to avoid that it registers with the CCXTStore as well which is why I've prevented that with if name == 'CCXTBroker': like this:

class MetaCCXTBroker(BrokerBase.__class__):
    def __init__(cls, name, bases, dct):
        '''Class has already been created ... register'''
        # Initialize the class
        super(MetaCCXTBroker, cls).__init__(name, bases, dct)
        if name == 'CCXTBroker':
            CCXTStore.BrokerCls = cls
Dave-Vallance commented 5 years ago

@sandroboehme Amazing stuff... Will try to review after I look at the feeds

armezit commented 3 years ago

@Dave-Vallance Any chance for this pull request to be merged into the master?