DaveLiddament / php-language-extensions

Attributes to define new PHP language features (that are enforced by static analysis)
MIT License
135 stars 5 forks source link

Improve CI #17

Open szepeviktor opened 1 year ago

szepeviktor commented 1 year ago

@DaveLiddament This is my default CI.

kép

Problems.

  1. There are no unit tests. As far as I see it is not possible to write unit tests.
  2. Other tools don't need multiple PHP versions.

Separate jobs and steps allow contributors to see where errors occur.

What are your thoughts?

DaveLiddament commented 1 year ago

Thanks for this.

There are a few bits I'd like from this.

I'm not sure about the increased complexity of the CI process. Given CI is so quick, both locally and on GH I don't see the value of making it more complex for this project.

szepeviktor commented 1 year ago

.gitattributes (I really should be adding this to all my projects).

It controls exported files.

The editorconfig is not something I've seen before, looks useful. Thanks for showing it to me. We should use this too.

It controls all characters of the project.

I'm not sure about the increased complexity of the CI process

Making every check a step in CI makes the UI very easy to read.

kép

szepeviktor commented 1 year ago

Reducing my default CI now ... 🏃🏻‍♂️

szepeviktor commented 1 year ago

Done 🍏

kép

MGatner commented 10 months ago

As a follower of this repo: I appreciate the work but don't find that the enumeration of CI results in the UI adds anything. Maybe if it helps contributors...