DaveLiddament / php-language-extensions

Attributes to define new PHP language features (that are enforced by static analysis)
MIT License
135 stars 5 forks source link

Add support for PHP 8.4.* #38

Closed mkoprek closed 3 weeks ago

mkoprek commented 3 weeks ago

Require: https://github.com/vimeo/psalm/pull/10928

DaveLiddament commented 3 weeks ago

@mkoprek Thanks for your help with this PR. Really appreciate your help on it.

Given this project only contains attributes, I wonder if having both PHPStan and Psalm is overkill?

Options I see:

The benefit of the first option is the phpstan rules for this can be upgraded for 8.4.

Have you any thoughts on the above, or a better suggestion?

mkoprek commented 3 weeks ago

Hey,

From mine personal perspective I think using both tools is an overkill. We are using in all projects phpstan and it is doing it job very well.

I would choose option one, I will push code with changes for it.

Thanks for fast response :)