search

DaveLiddament / sarb

Static Analysis Results Baseliner
MIT License
162 stars 17 forks source link

Copy code used from Webmozart's path-util into SARB #108

Closed DaveLiddament closed 2 years ago

DaveLiddament commented 2 years ago

webmozart/path-util is deprecated. Copy the code used by SARB into a new file src/Domain/Utils/Path.php. Copy test code too and update code to PHP7.3

jdreesen commented 2 years ago

See #107. symfony/filesystem is kind of a successor of webmozart/path-util: https://symfony.com/blog/new-in-symfony-5-4-filesystem-path-class#comment-24757

DaveLiddament commented 2 years ago

Given SARB's use case it will probably be used in with older code bases. I'm trying to keep SARB's dependencies as wide as possible. It's main dependencies are the Symfony components and my aim is for SARB to work with all supported versions of Symfony components (and PHP versions). The restriction to Symfony filesystem 5.4 is too tight. For adding a new Symfony library it would ideally satisfy the version constraints 4.4 || ^5.0 || ^6.0. Hence this issue to copy code into SARB's codebase.

DaveLiddament commented 2 years ago

Fixed by #110