DaveLuhman / toolkeeper

Tool Crib Web Application
2 stars 0 forks source link

Remove serial number column and add service assignment name to Dashboard table #222

Closed DaveLuhman closed 2 months ago

DaveLuhman commented 2 months ago

This pull request removes the serial number column from the Dashboard table and replaces it with the service assignment name. This change improves the clarity and accuracy of the information displayed in the table. Additionally, it enhances the user experience and ensures consistency with the rest of the application.

Fixes Dashboard #216


This change is Reviewable

deepsource-io[bot] commented 2 months ago

Here's the code health analysis summary for commits 07246c7..50fc859. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 1 occurence introduced
View Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.
DaveLuhman commented 2 months ago

Codacy and CodeQL scan failures are false positives. dotEnv cannot be skipped or the script doesn't know where to find the db. The codeQL scans point to "user controlled inputs" when they're hidden values sourced from sanitized inputs from the previous page render/load.

Approved for merge.