search

DaveMDS / node-red-contrib-tasmota

Tasmota devices for NodeRed
MIT License
23 stars 9 forks source link

Node status unclear #4

Closed josephdouce closed 4 years ago

josephdouce commented 4 years ago

When node is connected to broker but the device is offline (and never been online) the node status shows "connected" it is not clear that the device is offline as it is reporting the broker connection status.

If the device subsequently comes online and then goes offline the LWT is received and the status "Offline" and show correctly.

An additional status for when the broker is online but the device is offline would be beneficial. e.g.

Red - Broker Unavailable Yellow - Broker Connected, Device Offline Green - Online

josephdouce commented 4 years ago

I'll see if I can fix this and make a pull request

josephdouce commented 4 years ago

I checked the node-red git hub, the broker connection is setting the status, this also means the setting the status on broker connections is redundant and can be removed, tested.

DaveMDS commented 4 years ago

Indeed this is a know issue: the tasmota-node and the broker-node are fighting for the status-label. The first "connected" status is setted by the broker-node and I did not found a solution to fix this, did you found one?

josephdouce commented 4 years ago

Still working on it, it's hard because it's not instant so you need an asyn function to wait for the connection, bit the .register function doesn't return anything so no way to know it's complete.

DaveMDS commented 4 years ago

This should be fixed now, can you please give it a try?

josephdouce commented 4 years ago

Will test today

On Thu, Apr 9, 2020 at 7:47 AM Dave Andreoli notifications@github.com wrote:

This should be fixed now, can you please give it a try?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DaveMDS/node-red-contrib-tasmota/issues/4#issuecomment-611360303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN74YYLJLJEYHC7RL7HKLTRLVVPTANCNFSM4K4NUP2A .

-- Kind Regards Joseph Douce BEng (Hons) josephdouce@gmail.com

DaveMDS commented 4 years ago

Any news on this?

josephdouce commented 4 years ago

I'm in the process of moving house so my smart home gear is all packed away hence why I have been AFK. Sorry about that. Ill get to it as soon as I can

On Thu, Apr 30, 2020 at 7:55 AM Dave Andreoli notifications@github.com wrote:

Any news on this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DaveMDS/node-red-contrib-tasmota/issues/4#issuecomment-621649190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN74Y2SYSTTHIYPMDZBFDLRPEOETANCNFSM4K4NUP2A .

-- Kind Regards Joseph Douce BEng (Hons) josephdouce@gmail.com

DaveMDS commented 4 years ago

Ok, no problem, I tested this quite well, it works well IMO. I'm closing the issue, feel free to reopen if needed