search

DavePearce / JavaAVR

Simple AVR simulator written in Java
Apache License 2.0
9 stars 2 forks source link

Javadoc compilation errors #13

Open gracegrimwood opened 6 years ago

gracegrimwood commented 6 years ago

At AvrInstruction.java:428 the parameter name specified is incorrect, and thus Eclipse throws an error when compiling Javadoc. The correct param is "opcode" as "format" is not a parameter for the method toMask.

gracegrimwood commented 6 years ago

I've just tried to compile the rest of the code's Javadoc, and found a few more issues of a similar nature. In addition to the one above, Wire.java:22, Wire.java:30, DecoderGenerator.java:215, AvrEncodingTests.java:72, and AvrEncodingTests.java:130 all have the same issues of incorrect parameter names, and AVR.java:129 and AbstractSerialPeripheral.java:134 have @return's where there should be none.