ApCalibrate was written assuming the master dark was not bias subtracted, based on the 2020-03 series of iTelescope T05 calibration files. The latest T05 calibration, 2021-02-14, differs from this in having the (huge) bias already subtracted from the master dark files.
This will break the current ApCalibrate. Options:
Rewrite and make use of CALSTAT flags that iTelescope writes. The 2020-03 master darks have M, which I presume means median, while the 2021-02-14 files have BM where the B probably stands for bias-subtracted. Pro: automated solution; Con: only works for files matching this convention.
Rewrite and add command line flag to specify whether masters require bias subtraction before exposure-scaling. Pro: general solution; Con: user must know the answer themselves, and what should the default be?
Should probably also add a sanity check in the code to see that sigma_clipped_median(master_dark) >= sigma_clipped_median(master_bias).
ApCalibrate was written assuming the master dark was not bias subtracted, based on the 2020-03 series of iTelescope T05 calibration files. The latest T05 calibration, 2021-02-14, differs from this in having the (huge) bias already subtracted from the master dark files.
This will break the current ApCalibrate. Options:
CALSTATflags that iTelescope writes. The 2020-03 master darks haveM, which I presume means median, while the 2021-02-14 files haveBMwhere theBprobably stands for bias-subtracted. Pro: automated solution; Con: only works for files matching this convention.Should probably also add a sanity check in the code to see that sigma_clipped_median(master_dark) >= sigma_clipped_median(master_bias).