search

DaveTCode / GBADotnet

A C#/net core GBA emulator
MIT License
20 stars 1 forks source link

Pokemon firered logo is brightened incorrectly #24

Closed DaveTCode closed 2 years ago

DaveTCode commented 2 years ago

image

It makes sense that it behaves this way BLDCNT has BG0 set as primary target and brighten as the color mode. Then BLDY is set to 0xD which corresponds to 13. So it should be lightened by a factor of 13/16 unless I've misread something.

DaveTCode commented 2 years ago

Obviously caused by #3

DaveTCode commented 2 years ago

The only interesting oddity here is that the object window is enabled. Maybe that affects things somehow?

DaveTCode commented 2 years ago

I think what's happening here is that OBJ window is enabled and there is a single obj window sprite at 448,251 at 64*64 size.

Blending is disabled outside the window regions and enabled inside the obj window but I think that the OBJ window doesn't overlap with the overly highlighted font.

So this amounts to me writing the proper implementation of obj window and then using this as a test case for it