Implement Skip Image forward and backward

Davejkane / riv

Riv - The Rust Image Viewer

MIT License

99 stars 10 forks source link

Implement Skip Image forward and backward #20

Closed Davejkane closed 5 years ago

Davejkane commented 5 years ago

Add SkipForward and SkipBack to Action Enum in ui.rs
In event_action function in ui.rs map w and PageUp to SkipForward
In event_action function in ui.rs map b and PageDown to SkipBack
In run in program.rs match SkipForward to skip_forward function
In run in program.rs match SkipBack to skip_back function
In new skip_forward and skip_backward functions, move by 10% of len of images
If len < 10 move by one image, if 10 < len < 20 move by 2 images etc
Once skip length is determined, make the call to increment or decrement with the skip length.

gurgalex commented 5 years ago

If len < 10 move by one image, if 10 < len < 20 move by 2 images etc

Would cutting it off at 10% be fine? 1 step: <= 10

2 step: 10 < len <= 20

What did you want for the multiples of 10 if that is not the case?

gurgalex commented 5 years ago

What should be the default behavior if there is not 10% left to skip?

Should the viewer take the user to the last/first image?

Or, should it wrap around?

Davejkane commented 5 years ago

I mean I'm open to suggestions on this one, but I was basically thinking 10% of length, rounding up. I worded it pretty poorly I can see.

As for what to do when there is less than 10% left, we should go to the last image. I don't think there should ever be wrapping around. If you want to go back to the first image, it's just a keystroke away (g). Thanks for taking that into consideration, I hadn't thought of that.