search

Davejkane / riv

Riv - The Rust Image Viewer
MIT License
99 stars 10 forks source link

Info Bar #34

Closed Davejkane closed 5 years ago

Davejkane commented 5 years ago

This PR includes a what is needed to implement an info bar at the bottom of the window.

gurgalex commented 5 years ago

Still a draft I know, but I'll be basing future/current pull requests on this branch's progress.

Some other things.

The infobar covers the portion of the image it takes up. Should the image be resized to not be covered up? (toggleable of course if desired)

gurgalex commented 5 years ago

Transparency toggle/setting for infobar could be an option (won't get in the way of the image too much, but can still see the info if needed)

Davejkane commented 5 years ago

Yeah, I'm aware of the issue of the bar covering up the image. I've being using this in practice already and I really don't mind it. I think we can follow this up in another PR, coz it is worth looking at. We'll probably also need to look at the styling of the bar, coz I am definitely no artist :)

gurgalex commented 5 years ago

Won't be able to fully review this for about half a day. Initial thought incoming.

Davejkane commented 5 years ago

No worries, there's no rush.

gurgalex commented 5 years ago

Found the font crates that alacritty (GPU accelerated terminal) uses for each platform as well.

https://github.com/jwilm/alacritty/blob/master/font/Cargo.toml

Davejkane commented 5 years ago

Grouping program into mod.rs and render.rs is really just to break up an impl block that was getting too big for one file. I'm not a big fan of giant source files. I've handled the mod and use statements such that render is not a separate module.

Davejkane commented 5 years ago

Can you please start a review on this and request any further changes you'd like to see, or otherwise approve?