search

Davejkane / riv

Riv - The Rust Image Viewer
MIT License
99 stars 10 forks source link

Command line flag for full screen #39

Closed Davejkane closed 5 years ago

Davejkane commented 5 years ago

Allow an extra command line flag in cli.rs, probably -F to allow the app to be launched in full screen mode.

Currently the window is built before parsing the command line arguments, so this will need to be taken care of. After that it should just be a boolean, that defaults to false. If true the let window = line in main will have to be built differently, with resizable removed, display bounds removed and position centred removed, and fullscreen added.

It could look like let window = if fullscreen {...} else {...}

gurgalex commented 5 years ago

@Davejkane can I take this issue (and refactoring cli), or are you already working on moving cli parsing to happen before window creation?

Davejkane commented 5 years ago

@gurgalex go for it. I hadn't started on it yet.

gurgalex commented 5 years ago

What shortcut key should switch between fullscreen and windowed mode? F and F11 seems like a good choice.

Davejkane commented 5 years ago

They seem like good choices to me.