Daveyx0 / PrimitiveMobs

34 stars 13 forks source link

Crash when Chameleon walks over Agricraft's Crop Sticks #122

Open wetbrownsauce opened 6 years ago

wetbrownsauce commented 6 years ago

I have found an issue with Chameleons when passing over Crop Sticks from Agricraft. The issue results in a game crash, however, when on a multiplayer server the server itself doesn't crash, only the clients within range of the offending Chameleon. Once a Chameleon has found a set of Crop Sticks to sit on it will be impossible for anyone crashed by this to log back in until the Chameleon is removed. I haven't tested this with the Camouflage armor on a player but it might result in the same outcome.

This happens on both the version of forge I was running during the crash as well as the most recent version of forge.

Details have been included below, as well as the crash report itself.

Expected Behavior:

Actual Behaviour:

Steps to reproduce:

Crash Report Report on Pastebin

Daveyx0 commented 5 years ago

Thanks and sorry for the late response. Should be fixed in the 1.2 alpha. Need to confirm.

Daveyx0 commented 5 years ago

I investigated and there appears to be something going wrong when my ColorUtil class tried to get Quads from their BakedInfBlockModel. However I have nullchecks up the wazoo there, so I don't think I can fix it on my end. I also made an exception for codeChickenLibrary in my ColorUtil but that's cause they change so many blocks that's it was unavoidable. This appears to be on the end of InfinityLib.

This is where it goes wrong for me: https://github.com/Daveyx0/MultiMob/blob/6c2c1d3d603672a4fa3cd2cac84cf70f5b8a704a/main/java/net/daveyx0/multimob/util/ColorUtil.java#L101

and what it tries to get is: https://github.com/InfinityRaider/InfinityLib/blob/c427fea603c0eee50b44c59759cd78fa3a4d14ee/src/main/java/com/infinityraider/infinitylib/render/block/BakedInfBlockModel.java#L72