One of the users on my server is having issues with a treasure slime that they gave a dark oak chest to.
From what I can see in the code, an incorrect assumption is being made thatItemStack::getMetaData is guaranteed to be a valid state in it's ItemBlock's block's blockstate container. I'm surprised this crash doesn't happen more regularly, especially with modded items.
You definitely want to check to make sure that ItemStack::getMetaData is at least < getValidStates().size() at some point in the mix if you're going to be relying on this functionality. You can probably fall back on the standard getItemStackColour utility function.
Either way, there isn't actually any guarantee that the metadata of an ItemBlock has any relevance to its states, at least as far as I'm aware.
Crash log here: https://paste.dimdev.org/dagofiqapa.mccrash
One of the users on my server is having issues with a treasure slime that they gave a dark oak chest to.
From what I can see in the code, an incorrect assumption is being made that
ItemStack::getMetaDatais guaranteed to be a valid state in it's ItemBlock's block's blockstate container. I'm surprised this crash doesn't happen more regularly, especially with modded items.You definitely want to check to make sure that
ItemStack::getMetaDatais at least <getValidStates().size()at some point in the mix if you're going to be relying on this functionality. You can probably fall back on the standardgetItemStackColourutility function.Either way, there isn't actually any guarantee that the metadata of an ItemBlock has any relevance to its states, at least as far as I'm aware.