search

David-Desmaisons / Vue.resize

Vue directive to detect resize events with deboucing and throttling capacity.
MIT License
326 stars 36 forks source link

Removed polyfills #19

Open ELFoglalt opened 4 years ago

ELFoglalt commented 4 years ago

Fixes #14. Removes polyfills for reasons detailed in the issue.

David-Desmaisons commented 4 years ago

Thanks for the PR. Could you please add the corresponding explanation and link to pollyfill in the README?

ELFoglalt commented 4 years ago

Added an extra paragraph after the installation section.

Considering this may be a breaking change in some browsers, I assume a version number bump would also be required?

David-Desmaisons commented 4 years ago

Considering this may be a breaking change in some browsers, I assume a version number bump would also be required?

Correct

ELFoglalt commented 4 years ago

Hmm... Following semver this would have to be 1.2.0->2.0.0 then? Kind of a big jump for such a small change. But technically we are no longer compatible with ^1.x.x and possibly break things, right?

David-Desmaisons commented 4 years ago

Excatly

ELFoglalt commented 4 years ago

Done, and re-built so that the dist folder is also up to date with the changes.